You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some minor code improvements not yet implemented from a review of the initial commit:
Delete media/.gitignore and use root .gitignore instead. Note: code was copied from bakerydemo, although approach is likely not necassary.
Pass request object when calling .url on a page to avoid performance issues (see LinkStructValue class).
Improve handling of placeholder image. get_placeholder_image shouldn't try and provide a fallback image or should at least point to a static file instead.
Remove querystring_modify, perhaps with a tag from wagtailadmin_tags if possible.
Update responsive images, Resolution switching is being used for srcset, although the same values are being used across different display resolutions (1x vs 2x).
The text was updated successfully, but these errors were encountered:
Some minor code improvements not yet implemented from a review of the initial commit:
Delete
media/.gitignore
and useroot .gitignore
instead.Note: code was copied from bakerydemo, although approach is likely not necassary.
Pass request object when calling .url on a page to avoid performance issues (see
LinkStructValue
class).Improve handling of placeholder image.
get_placeholder_image
shouldn't try and provide a fallback image or should at least point to a static file instead.Remove
querystring_modify
, perhaps with a tag fromwagtailadmin_tags
if possible.Update responsive images, Resolution switching is being used for srcset, although the same values are being used across different display resolutions (1x vs 2x).
The text was updated successfully, but these errors were encountered: