Normalize supports arbitrary dimensions #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmassa I think if you're changing the order of arguments like here, it's worth adding a check that |
|
@apaszke I agree. just pushed a diff checking that |
|
I forgot to consider that previously saved models do not have the |
|
Fixed case of old saved models. To make it simple I just added the default value in the forward/backward calls, I didn't overwrite the |
Assert that dim is integer in Normalize
|
One note about the negative indexes, if you want I could also add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs + tests.
Also, cleans a bit some unnecessary temporary variables.
Important remark: I added the dimension parameter as the second argument to the constructor, making the
epsthe third one. This breaks code that changed the defaultepsduring initialization, but I felt thatdimcoming afterepsfelt weird. Let me know if you prefer to letdimthe last argument.