From 51c05d9bba1ef13e4b1e715cfcad72937730d1ee Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Tue, 27 Aug 2024 10:28:49 +0300 Subject: [PATCH 1/7] Update changeset file --- docs/contribution/changeset-guidelines.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index c81abce5c7..ffb36c34c5 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -32,6 +32,8 @@ Please use this format: ``` --- '@toptal/[package]': [version bump] +//if the version bump is major, please also add the line below in order to have this comments visible in the release notes of Picasso patch +'@toptal/picasso': patch --- --- From ab59e5a747c67d68821a045b4d28a23381ef05ad Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Tue, 27 Aug 2024 10:37:12 +0300 Subject: [PATCH 2/7] Fix typo --- docs/contribution/changeset-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index ffb36c34c5..385529e529 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -32,7 +32,7 @@ Please use this format: ``` --- '@toptal/[package]': [version bump] -//if the version bump is major, please also add the line below in order to have this comments visible in the release notes of Picasso patch +//if the build bump is major, please also add the line below to have the changeset comments visible in the Picasso patch release notes. '@toptal/picasso': patch --- From 6c212c1b9172ddae2b4636d8aa336d051850a93f Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Tue, 27 Aug 2024 11:22:41 +0300 Subject: [PATCH 3/7] Fix message structure --- docs/contribution/changeset-guidelines.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index 385529e529..6d877b87e4 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -32,8 +32,7 @@ Please use this format: ``` --- '@toptal/[package]': [version bump] -//if the build bump is major, please also add the line below to have the changeset comments visible in the Picasso patch release notes. -'@toptal/picasso': patch +//if the version bump is major, please also add `'@toptal/picasso': patch` to have the changeset comments visible in the Picasso patch release notes. --- --- From 14b3a2e83afc443b3f126ac3e539a782a1e5852b Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Thu, 5 Sep 2024 15:18:20 +0300 Subject: [PATCH 4/7] Update changeset guidelines --- docs/contribution/changeset-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index 6d877b87e4..605e3df594 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -32,7 +32,7 @@ Please use this format: ``` --- '@toptal/[package]': [version bump] -//if the version bump is major, please also add `'@toptal/picasso': patch` to have the changeset comments visible in the Picasso patch release notes. +//if the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that depend on picasso, usually of the form `@toptal/picasso-show-more`. --- --- From e73a2f7998a4081f96d2e2f8e7cd960967083fa6 Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Thu, 5 Sep 2024 17:58:09 +0300 Subject: [PATCH 5/7] Reformulate the changeset message --- docs/contribution/changeset-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index 605e3df594..d4ec72c7d2 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -32,7 +32,7 @@ Please use this format: ``` --- '@toptal/[package]': [version bump] -//if the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that depend on picasso, usually of the form `@toptal/picasso-show-more`. +//if the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that Picasso depends on, usually of the form `@toptal/picasso-package-name`. --- --- From 93d8aa0cbcd3a35273c2429ffbb12b613d9bf6d0 Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Mon, 7 Oct 2024 11:08:51 +0300 Subject: [PATCH 6/7] Insert note icon --- docs/contribution/changeset-guidelines.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index d4ec72c7d2..6748a5ae3c 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -29,10 +29,12 @@ The same as commits, we write changeset in `present simple`. Please use this format: +> [!NOTE] +> If the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that Picasso depends on, usually of the form `@toptal/picasso-package-name`. + ``` --- '@toptal/[package]': [version bump] -//if the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that Picasso depends on, usually of the form `@toptal/picasso-package-name`. --- --- From bf7019f7a73369575167739111058314f5b61e3d Mon Sep 17 00:00:00 2001 From: Adrian Contiu Date: Tue, 8 Oct 2024 16:52:25 +0300 Subject: [PATCH 7/7] Address review comments --- docs/contribution/changeset-guidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contribution/changeset-guidelines.md b/docs/contribution/changeset-guidelines.md index 6748a5ae3c..3c251efe02 100644 --- a/docs/contribution/changeset-guidelines.md +++ b/docs/contribution/changeset-guidelines.md @@ -30,7 +30,7 @@ The same as commits, we write changeset in `present simple`. Please use this format: > [!NOTE] -> If the version bump is major, please also add `'@toptal/picasso': patch` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is only required for packages that Picasso depends on, usually of the form `@toptal/picasso-package-name`. +> If the version bump is major, please also add `'@toptal/picasso': patch | minor | major` and don't forget to include the heading to have the changeset comments visible in the Picasso patch release notes. This is required for packages that Picasso depends on, usually these packages have name like `@toptal/picasso-package-name`. ``` ---