Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PF-235] Add 2nd batch of sidebar icons #4634

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[PF-235] Add 2nd batch of sidebar icons #4634

merged 2 commits into from
Jan 8, 2025

Conversation

vedrani
Copy link
Contributor

@vedrani vedrani commented Jan 7, 2025 •
edited
Loading

PF-235

Description

Add new set of BASE icons needed for sidebar

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f662e13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@toptal/picasso-icons Minor
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@toptal/picasso-accordion Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-avatar Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-button Patch
@toptal/picasso-calendar Patch
@toptal/picasso-carousel Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-input Patch
@toptal/picasso-input-adornment Patch
@toptal/picasso-list Patch
@toptal/picasso-logo Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-notification Patch
@toptal/picasso-number-input Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-page Patch
@toptal/picasso-password-input Patch
@toptal/picasso-rating Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-show-more Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-pagination Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-radio Patch
@toptal/picasso-switch Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-date-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vedrani
Copy link
Contributor Author

vedrani commented Jan 7, 2025

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@56.0.6-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-accordion@3.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-account-select@3.0.14-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-amount@1.0.10-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-application-update-notification@2.0.28-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-autocomplete@5.0.18-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-avatar-upload@3.0.20-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-backdrop@1.0.9-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-breadcrumbs@3.0.8-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-calendar@4.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-carousel@4.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-charts@59.0.4-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-checkbox@5.0.9-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-codemod@6.0.1-alpha-PF-235-add-sidebar-icons-2c38b1d32.318+2c38b1d32
yarn add @toptal/picasso-collapse@3.0.3-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-container@3.1.2-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-date-picker@3.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-date-select@1.0.65-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-dropdown@4.2.2-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-dropzone@5.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-empty-state@2.0.11-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-environment-banner@3.0.1-alpha-PF-235-add-sidebar-icons-2c38b1d32.113+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-file-input@4.0.15-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-helpbox@5.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-input-adornment@3.0.8-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-modal-context@1.0.2-alpha-PF-235-add-sidebar-icons-2c38b1d32.377+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-notification@4.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-number-input@4.0.20-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-outlined-input@4.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-overview-block@4.0.4-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-pagination@4.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-password-input@5.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-pictograms@5.0.3-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-prompt-modal@2.0.28-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-provider@5.0.1-alpha-PF-235-add-sidebar-icons-2c38b1d32.196+2c38b1d32
yarn add @toptal/picasso-query-builder@8.0.12-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-rich-text-editor@17.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-section@5.0.17-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-shared@15.0.1-alpha-PF-235-add-sidebar-icons-2c38b1d32.275+2c38b1d32
yarn add @toptal/picasso-show-more@2.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-skeleton-loader@1.0.53-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32
yarn add @toptal/picasso-tagselector@3.1.18-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-tailwind@3.0.1-alpha-PF-235-add-sidebar-icons-2c38b1d32.62+2c38b1d32
yarn add @toptal/picasso-tailwind-merge@2.0.3-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-test-utils@1.1.2-alpha-PF-235-add-sidebar-icons-2c38b1d32.275+2c38b1d32
yarn add @toptal/picasso-timeline@5.0.4-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-timepicker@4.0.16-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-tooltip@2.0.2-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-tree-view@3.0.29-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/picasso-typography@4.0.3-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-typography-overflow@4.0.3-alpha-PF-235-add-sidebar-icons-2c38b1d32.22+2c38b1d32
yarn add @toptal/picasso-user-badge@5.1.9-alpha-PF-235-add-sidebar-icons-2c38b1d32.1+2c38b1d32
yarn add @toptal/[email protected]+2c38b1d32

@vedrani vedrani self-assigned this Jan 8, 2025
@vedrani vedrani marked this pull request as ready for review January 8, 2025 08:24
@vedrani vedrani requested a review from a team as a code owner January 8, 2025 08:24
@vedrani
Copy link
Contributor Author

vedrani commented Jan 8, 2025

@toptal-anvil ping reviewers

sashuk
sashuk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked locally and in visual diffs

@vedrani vedrani merged commit 37b95cc into master Jan 8, 2025
18 of 19 checks passed
@vedrani vedrani deleted the PF-235-add-sidebar-icons branch January 8, 2025 13:36
@toptal-build toptal-build mentioned this pull request Jan 8, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleksandrNechai OleksandrNechai OleksandrNechai approved these changes

@sashuk sashuk sashuk approved these changes

Assignees

@vedrani vedrani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedrani @toptal-devbot @sashuk @OleksandrNechai