Skip to content

Latest commit

 

History

History
110 lines (64 loc) · 7.05 KB

CONTRIBUTING.md

File metadata and controls

110 lines (64 loc) · 7.05 KB
Raw

Contributing to Picasso

👍🎉 First off, thanks for taking the time to contribute! 👍🎉

The following is a set of guidelines for contributing to Picasso and its packages, which are hosted in the Toptal Organization on GitHub. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request or on a slack channel. Picasso should serve to everyone, therefore if you dislike anything feel free to reach us out and propose changes 💗.

Table Of Contents

What should I know before I get started?

How Can I Contribute?

Why my first PR is taking too long to merge ?

Technical guides

Tutorials

What should I know before I get started?

About Picasso

Picasso is an internal company open source project — yes we just invented this approach 😄, which should help everyone inside Toptal to focus on their work and forgot about issues with design sync-up, repeating same implementations of UI/UX patterns, and follow same conventions in all FE projects.

Picasso is collectively owned, so all of us maintain and keep consistency and quality on highest level.

IMPORTANT: Design decisions

We try to have everything inside Picasso synced with latest design proposal called BASE — if you see this name it's always referring to our BASE design which you could probably already see inside TopScheduler or Portal projects. Any design decision made should be discussed with us and could be also discussed on #-base-core channel through slack prior to its implementation.

How can I contribute?

  • Make sure tests pass by running yarn test

  • You can also use @toptal-anvil ping reviewers to ping the reviewers back to get their approvals after resolving the stated issues

Your first contribution

In following section we would like to describe some key pain points of creating your first PR to the Picasso repository.

We understand many cases when you are pushed by deadlines and you need to provide some feature and at the same time you would like to contribute to Picasso, but we all need to understand purpose of Picasso. As we are building core library for ALL things created at Toptal we need to put a strong emphasis on code quality and readability. Not only strong, but maximum possible level of quality, you need to treat Picasso as tool for everyone therefore even some code looks clear to you, it might not be very clear to others. In your first PR probably you will receive many comments regarding code conventions, codestyle and refactoring your code, which may look to you unnecessary but only with that we can keep level of quality and easiness of next contributions at best level.

Reporting Bugs

This section guides you through submitting a bug report for Picasso. Following these guidelines helps maintainers and other engineers understand your report 📝, reproduce the behavior 💻 💻, and find related reports 🔎.

In case that you found something which doesn't work as advertised feel free to reach out us on #-frontend-exp-core channel with a question, we will either guide you how to solve that issue ask you to create a bug inside GitHub repository and in most cases we will propose you a workaround to immediately unblock you if it's possible.

Creating new components

Picasso should cover all repetitive and reusable components used at Toptal. As we can't fully track every line created by you, you are welcomed to propose any new component which should be part of Picasso and you see that it might be a helpful addition used also by the other people. Don't be afraid to raise any question and propose new ideas to us.

Showcase examples

We showcase how to use Picasso components via storybook. If you have new case and want to show other users how to use the component, create a new example.

Alpha package release

If you need to test the changes in your project, you can release an alpha package by adding this comment in the PR: @toptal-bot run package:alpha-release.

Release

We use changesets to manage releases for Picasso packages.

As a contributor, we expect you to create a "changeset" file for the changes you've made. You can do it by running:

yarn changeset

The "changeset" file should:

You can also check how to add changeset for more details.

After the PR is merged, an additional "Version Packages [skip ci]" PR is created with the version bump, and changelogs are generated. An FX team member will merge this PR to make a release.

Why my first PR is taking too long to merge?

We use strict code conventions and building UI framework, so you need to take into consideration that when the contribution works for your particular case, it might not work for 10 others. Different environments which can reuse components from Picasso could lead us to a different behaviours which we need to minimize as much as possible.

We try to do our best while reviewing PR's but as we and other people are already heavily contributing to Picasso some things could look obvious to us but not to you. We appreciate your patience inside first PR and if you feel that you didn't get enough information from our contribution guide, raise this issue and we will update documentation with necessary information.

How I can preview changes or send a link to anyone with my changes?

We got you covered! Every commit in PR is automatically built with Storybook and published online so you can easily share any work in progress to your colleague or designers if you need. This job is finished even if you have errors inside specs or if anything else is failing. ✌️