From 7efd147e0888c5c6754a4d7ee2691a2ff5c82072 Mon Sep 17 00:00:00 2001 From: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com> Date: Thu, 7 Dec 2023 15:48:37 -0500 Subject: [PATCH] Use mstore_32bytes to optimize decode_int_given_len (#1413) --- evm/src/cpu/kernel/asm/rlp/decode.asm | 44 ++++++++------------------- 1 file changed, 13 insertions(+), 31 deletions(-) diff --git a/evm/src/cpu/kernel/asm/rlp/decode.asm b/evm/src/cpu/kernel/asm/rlp/decode.asm index 327edcf1c5..dd990bbd37 100644 --- a/evm/src/cpu/kernel/asm/rlp/decode.asm +++ b/evm/src/cpu/kernel/asm/rlp/decode.asm @@ -131,37 +131,19 @@ decode_rlp_list_len_big: // Pre stack: pos, len, retdest // Post stack: pos', int global decode_int_given_len: - %stack (pos, len, retdest) -> (pos, len, pos, retdest) + DUP2 ISZERO %jumpi(empty_int) + %stack (pos, len, retdest) -> (pos, len, pos, len, retdest) ADD - // stack: end_pos, pos, retdest - SWAP1 - // stack: pos, end_pos, retdest - PUSH 0 // initial accumulator state - // stack: acc, pos, end_pos, retdest - -decode_int_given_len_loop: - // stack: acc, pos, end_pos, retdest - DUP3 - DUP3 - EQ - // stack: pos == end_pos, acc, pos, end_pos, retdest - %jumpi(decode_int_given_len_finish) - // stack: acc, pos, end_pos, retdest - %shl_const(8) - // stack: acc << 8, pos, end_pos, retdest - DUP2 - // stack: pos, acc << 8, pos, end_pos, retdest - %mload_kernel(@SEGMENT_RLP_RAW) - // stack: byte, acc << 8, pos, end_pos, retdest - ADD - // stack: acc', pos, end_pos, retdest - // Increment pos. - SWAP1 - %increment - SWAP1 - // stack: acc', pos', end_pos, retdest - %jump(decode_int_given_len_loop) + %stack(pos_two, pos, len, retdest) -> (pos, len, pos_two, retdest) + PUSH @SEGMENT_RLP_RAW + PUSH 0 //context + MLOAD_32BYTES + // stack: int, pos', retdest + %stack(int, pos, retdest) -> (retdest, pos, int) + JUMP -decode_int_given_len_finish: - %stack (acc, pos, end_pos, retdest) -> (retdest, pos, acc) +empty_int: + // stack: pos, len, retdest + %stack(pos, len, retdest) -> (retdest, pos, 0) JUMP +