Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

godep save ./... in top-level dir saves nothing #468

Open
jmhodges opened this issue May 15, 2016 · 4 comments
Open

godep save ./... in top-level dir saves nothing #468

jmhodges opened this issue May 15, 2016 · 4 comments

Comments

@jmhodges
Copy link
Contributor

The code in https://github.com/jmhodges/howsmyssl/tree/test_allow (jmhodges/howsmyssl@45ce864) has a dependency on "golang.org/x/net/publicsuffix" in allow.go, but running godep save ./... in the top directory doesn't vendorize it.

Instead, an empty Deps list in Godeps.json is made.

@freeformz
Copy link

$ cd ~/go/src/github.com
$ mkdir jmhodges
$ cd jmhodges
$ git clone https://github.com/jmhodges/howsmyssl.git
Cloning into 'howsmyssl'...
remote: Counting objects: 1283, done.
remote: Compressing objects: 100% (61/61), done.
remote: Total 1283 (delta 28), reused 0 (delta 0), pack-reused 1216
Receiving objects: 100% (1283/1283), 800.82 KiB | 324.00 KiB/s, done.
Resolving deltas: 100% (727/727), done.
Checking connectivity... done.
$ cd howsmyssl
$ ls
Dockerfile                            allow_test.go                         howsmyssl-gcloud-credentials.json.enc static
LICENSE                               client_info.go                        howsmyssl.go                          templates
README.md                             config                                index_test.go                         tls
all_suites.go                         conn.go                               insecure_suites.go                    travis_docker_push.sh
allow.go                              gzip                                  stat_writer.go                        vendor
$ git checkout test_allow
Branch test_allow set up to track remote branch test_allow from origin.
Switched to a new branch 'test_allow'
$ go get -u golang.org/x/net/publicsuffix
$ godep save ./...
$ cat Godeps/Godeps.json
{
    "ImportPath": "github.com/jmhodges/howsmyssl",
    "GoVersion": "devel-8f48efb",
    "GodepVersion": "v67",
    "Packages": [
        "./..."
    ],
    "Deps": [
        {
            "ImportPath": "golang.org/x/net/publicsuffix",
            "Rev": "ef00b378c73f107bf44d5c9b69875255ce89b79a"
        }
    ]
}

Interestingly golang.org/x/net/publicsuffix isn't in vendor though.

Looking more into why that is.

@freeformz
Copy link

Ugh. well, in my case it did "vendor" it, just into a _workspace. So I found a different bug.

@freeformz
Copy link

The bug I discovered is fixed in v69. So I can't replicate this issue.

Perhaps there is another case sensitivity issue I haven't caught? What is the output of echo $GOPATH and pwd when you do a save that doesn't work?

@freeformz
Copy link

@jmhodges I can't replicate this. Any further info?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants