Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Item error on detele #1744

Open
FunkyCss opened this issue Jan 31, 2025 · 3 comments
Open

Accordion Item error on detele #1744

FunkyCss opened this issue Jan 31, 2025 · 3 comments

Comments

@FunkyCss
Copy link

I am using the latest RC of GBP and today noticed that if you use accordions and you delete the paragraph of an single item, there is going to be the gutenberg notice that this block has been facing an error.

Maybe here is a good idea to just remove the paragraph and not the container that is wrapping it.

@FunkyCss FunkyCss added the triage Awaiting review label Jan 31, 2025
@tomusborne tomusborne added Needs Details and removed triage Awaiting review labels Feb 3, 2025
@tomusborne
Copy link
Owner

@FunkyCss I'm not able to reproduce this. Can you provide a video and/of the block HTML so I can take a closer look?

Thanks!

@FunkyCss
Copy link
Author

FunkyCss commented Feb 3, 2025

Hello Tom,

Apologies for not providing more details or screenshots at the moment, as I’m currently out of the office.

To be more specific, if you already have an accordion built with V1 blocks and attempt to make changes—such as changing a Heading to Text or a Paragraph to Text—you’ll encounter an issue. Additionally, I noticed problems when deleting a Paragraph block as well.

This website was originally built with V1, and I’m in the process of transitioning it to V2. So far, these issues have only appeared in the accordion component for me.

I’ll be back in the office tomorrow and will share a video to provide more clarity. Let me know if there’s anything else I can check in the meantime.

Thanks!

@FunkyCss
Copy link
Author

FunkyCss commented Feb 3, 2025

The issue was more intense as I remember if the block was a local pattern.

The issue was similar to this older issue that is closed right now
https://vimeo.com/1051704442/faacb8752c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants