Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why authenticate twice? #391

Open
teoArganaraz opened this issue May 9, 2024 · 2 comments
Open

Why authenticate twice? #391

teoArganaraz opened this issue May 9, 2024 · 2 comments

Comments

@teoArganaraz
Copy link

I was reading the code in detail and found that the validation of cookies in the linkedin class is also done in the client class in the authenticate method. There is a reaso or its only a duplication of code?

Linkedin class cookie validation
image

Client class cookie validation
image

@egor-ryashin
Copy link

egor-ryashin commented Sep 15, 2024

It's not clear what's wrong in the question, for example if cookies exist it won't do do_authentication_request and return - meaning no double authentication here.

@egor-ryashin
Copy link

But I see that if cookie is specified in the init then metadata is not fetched.

def __init__(
        self,
        username: str,
        password: str,
        *,
        authenticate=True,
        refresh_cookies=False,
        debug=False,
        proxies={},
        cookies=None,
        cookies_dir: str = "",
    ):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants