Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions remain unread #140

Open
Peter-maximus opened this issue Aug 5, 2023 · 19 comments
Open

Reactions remain unread #140

Peter-maximus opened this issue Aug 5, 2023 · 19 comments

Comments

@Peter-maximus
Copy link

If "Don't send read confirmations" and "Auto-send receipts on reply" is both turned on, it works correctly for messages, however not for reactions (those smileys etc.).
I mean that if i reply in the chat after reaction, the reaction reamains unread...

It seems that web whatsapp with incognito plugin doesn't show reaction state (read / unread), however whatsapp app in mobile takes it as unread (even if i reply on it in web whatsapp with incognito plugin) and once new message come it shows popup of new message together with previous unread reactions.
At the end if you receive number of reactions from different chats and read them all just on web whatsapp with incognito plugin and afterwards come just one new regular message then whatsapp app in mobile shows you all that reactions again as new repeatedly.

Only workaround now is to make those reaction read in whatsapp app in mobile.

@Peter-maximus Peter-maximus changed the title Reactions reamain unread Reactions remain unread Aug 5, 2023
@tomer8007
Copy link
Owner

I will try to fix this

@tomer8007 tomer8007 added the bug label Aug 5, 2023
@Peter-maximus
Copy link
Author

thx a lot

tomer8007 added a commit that referenced this issue Aug 10, 2023
@tomer8007
Copy link
Owner

This bug is due to cb01c48 which I commited last year because it addressed another issue which I can't remember (it had something to do with read receipt privacy settings).

Anyway I now reverted it in c9fc8f4 and if nothing bad will happen this will get into the next version in the store.

@Peter-maximus
Copy link
Author

thx

@tomer8007
Copy link
Owner

@Peter-maximus I think that for groups that are part of communities, a read-self is sent, so clicking on such a chat in this mode marks it as read.
Are you aware of a feature in communities where you can't see who read your message?

@Peter-maximus
Copy link
Author

Peter-maximus commented Sep 1, 2023 via email

@tomer8007
Copy link
Owner

tomer8007 commented Sep 1, 2023

@Peter-maximus Yes, but I'm saying it happens only in groups that are part of WhatsApp communities and only if the "fix" is on - not blocking read-self receipts.

@Peter-maximus
Copy link
Author

Peter-maximus commented Sep 1, 2023 via email

@Peter-maximus
Copy link
Author

any update on this?
the reactions remain unread...

@tomer8007
Copy link
Owner

Yes, This is because I saw that when I make the reactions read, it makes a side effect where it looks like messages in communities are marked as read when you click on them, even when the blocking is on.

If you don't care about this, you can fix it by removing one line of code:

(readConfirmationsHookEnabled && action == "receipt" && data["type"] == "read-self") ||

@Peter-maximus
Copy link
Author

Peter-maximus commented Oct 16, 2023 via email

@tomer8007
Copy link
Owner

tomer8007 commented Oct 17, 2023

How would you call such an option? It's a little weird.
What I can do is add a javascript variable that you can turn on or off.

@Peter-maximus
Copy link
Author

Peter-maximus commented Oct 17, 2023 via email

@tomer8007
Copy link
Owner

OK, well, I don't know if it's important enough, maybe in the future... What do you think about a javascript variable in the meantime?

@Peter-maximus
Copy link
Author

Peter-maximus commented Oct 18, 2023 via email

@tomer8007
Copy link
Owner

I mean that, you could open open the console (F12), and type, say, shouldSendReactionsReceipts = true, and from this moment until you close the window on the extension will not block receipts for reactions.

@Peter-maximus
Copy link
Author

that is very unconvenient, as it means every time i open whatsapp window i have to open console and write this command...

i think it is important to have this option within program GUI otherwise reaction messages left sticked in the notification bar on the phone with all the consequences mentioned above.
would you mind to implement it please?
thx a lot.

@tomer8007
Copy link
Owner

OK, I might implement that after I'll fix some more important bugs.

@tomer8007 tomer8007 reopened this Oct 19, 2023
@Peter-maximus
Copy link
Author

thx a lot again. have a nice evening

@tomer8007 tomer8007 removed the bug label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants