Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

norm.max() when doing batched validation #9

Open
ghost opened this issue Jul 6, 2023 · 0 comments
Open

norm.max() when doing batched validation #9

ghost opened this issue Jul 6, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 6, 2023

Shouldn't this line in mpnn.py:

edge_embeddings = F.relu(self.edge_feature_NN(torch.cat([embedded_edges, norm / norm.max()],dim=-1)))

be replaced with something like:
max_values, _ = torch.max(norm, dim=1, keepdim=True)
edge_embeddings = F.relu(self.edge_feature_NN(torch.cat([embedded_edges, norm / max_values], dim=-1))

so that the batches are each divided by the max of their part of the norm tensor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants