Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox render #11

Open
landsman opened this issue May 31, 2016 · 2 comments
Open

Checkbox render #11

landsman opened this issue May 31, 2016 · 2 comments

Comments

@landsman
Copy link

Hi,

i am thinking about implementation: https://github.com/flatlogic/awesome-bootstrap-checkbox. What you think?

@tomaj
Copy link
Owner

tomaj commented May 31, 2016

Hi

This library looks good, but html that you need to generate is diferent than bootstrap html:

This is bootstrap way:

<div class="checkbox">
  <label>
    <input type="checkbox" value="">
  </label>
</div>

And for this checkboxes you need to change it to

<div class="checkbox">
    <input type="checkbox" id="checkbox1">
    <label for="checkbox1">
        Check me out
    </label>
 </div>

And this should be breaking change for this library.

Maybe to create new nette "Renderer" that will generate this kind of output.

@landsman
Copy link
Author

Yea, i know, but this is a problem:
https://api.nette.org/2.4.0/source-Forms.Controls.Checkbox.php.html#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants