Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/opt/bin/xochitl script issues #908

Open
Havner opened this issue Sep 5, 2024 · 0 comments
Open

/opt/bin/xochitl script issues #908

Havner opened this issue Sep 5, 2024 · 0 comments
Labels
bug Something isn't working packages Add or improve packages of the repository

Comments

@Havner
Copy link

Havner commented Sep 5, 2024

Describe the issue
2 small issues in the script:

  1. The is-active function doesn't exist here
    https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/xochitl#L24
  2. The script masks non existing service (e.g. rm-sync):
    https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/xochitl#L20C1-L22C3
    And nothing unmasks it when uninstalling as the unmask option have different conditions in the postremove:
    https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/package#L110C1-L111C41

Not putting more info as this has been discussed in the discord and I think the code is clear enough to see the issues.

@Havner Havner added bug Something isn't working packages Add or improve packages of the repository labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

No branches or pull requests

1 participant