Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package_build build-dependency-aware #4

Open
matteodelabre opened this issue Mar 25, 2021 · 2 comments
Open

Make package_build build-dependency-aware #4

matteodelabre opened this issue Mar 25, 2021 · 2 comments
Labels
enhancement New feature or request workflows Repository workflows used to automate testing and building

Comments

@matteodelabre
Copy link
Member

The toltec-dev/toltec#274 PR added build-time dependencies and updated the repo_build script so that the dependencies of a recipe are always built before that recipe. However, it did not update the package_build script. As a consequence, users have to manually handle dependencies when building individual packages. To see the issue:

  • Try to build the zshelf package from an empty build directory. You’ll get an error saying that the /repo/Packages.gz file does not exist. This can be fixed by creating an empty Packages.gz file in the build/repo folder.
  • Even with the empty Packages.gz created, try to build the recrossable recipe. You’ll get an error saying that the libdlib cannot be found. This can be fixed by first building the libdlib recipe.

A better behavior would be for the package_build script to trigger the build of needed packages automatically when they are missing and to always create the packages index before running the build.

@matteodelabre matteodelabre transferred this issue from toltec-dev/toltec Jul 31, 2021
@matteodelabre
Copy link
Member Author

Since we’ve moved the build system in a separate project we need to rethink a little bit how we may solve this. We can’t simply “trigger the build of needed packages automatically when they are missing”, because the build script doesn’t know where all the recipe sources are located anymore.

A possible solution would be to generate a helpful error message, saying that one of the dependencies are missing for the build, clearly indicating which package is missing, and indicating what steps need to be taken to fix this.

@Eeems Eeems added enhancement New feature or request workflows Repository workflows used to automate testing and building labels Aug 1, 2021
@Eeems
Copy link
Member

Eeems commented Dec 16, 2023

I think it would make sense to allow passing in multiple package directories to build at once, and have all the dependency handling that the toltec build system had implemented. That or have some extra glue around that in toltec and just manually call the toltecmk code from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflows Repository workflows used to automate testing and building
Projects
None yet
Development

No branches or pull requests

2 participants