Skip to content

Commit cad1249

Browse files
committed
subscriber: update tracing-core to v0.1.33
The change #2954 was released in 0.3.19 (#3162). Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the `tracing` feature of `tracing-subscriber` would have no issue since it pulls in the higher version transitively. The specific feature used was implementing trait method `record_bytes` from the `field::Visit` trait on `JsonVisitor` from the tracing-subscriber json format module. (see linked #2945, or [ `impl field::Visit for JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491)) I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure. This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.
1 parent 44b9493 commit cad1249

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tracing-subscriber/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ local-time = ["time/local-offset"]
3939
nu-ansi-term = ["dep:nu-ansi-term"]
4040

4141
[dependencies]
42-
tracing-core = { path = "../tracing-core", version = "0.1.30", default-features = false }
42+
tracing-core = { path = "../tracing-core", version = "0.1.33", default-features = false }
4343

4444
# only required by the filter feature
4545
tracing = { optional = true, path = "../tracing", version = "0.1.41", default-features = false }

0 commit comments

Comments
 (0)