You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 2, 2018. It is now read-only.
Recently tried to use this timer for expiring a connection that was alive for over an 1hr 5mins (3,900,000ms), which is larger than the default values for num-slots (4,096 by default) and tick-duration (100ms by default).
Tested behavior was that the timer did not go off and notify the Future properly.
Possible solutions:
Return Result<()> for sleep(), timeout(), etc. where logic is checked such that duration <= num-slots * tick-duration.
Dynamically change num-slots or tick-duration (whichever makes sense) such that duration is scheduled correctly.
Any thoughts on the right way to proceed? Right now I can just adjust the tick-duration to 1000ms as I don't need precision, and I think I can work on a PR next week.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Recently tried to use this timer for expiring a connection that was alive for over an 1hr 5mins (3,900,000ms), which is larger than the default values for
num-slots
(4,096 by default) andtick-duration
(100ms by default).Tested behavior was that the timer did not go off and notify the Future properly.
Possible solutions:
sleep()
,timeout()
, etc. where logic is checked such thatduration <= num-slots * tick-duration
.Any thoughts on the right way to proceed? Right now I can just adjust the tick-duration to 1000ms as I don't need precision, and I think I can work on a PR next week.
The text was updated successfully, but these errors were encountered: