Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about missing CSRF validation in oauth example #2512

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Add note about missing CSRF validation in oauth example #2512

merged 1 commit into from
Jan 13, 2024

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented Jan 13, 2024 •
edited
Loading

Was recently made aware that our oauth example doesn't check the CSRF token. This adds a note to the example so people at least are aware of it. Also made an issue to get it fixed #2511

@davidpdrsn davidpdrsn requested a review from jplatte January 13, 2024 13:40
@davidpdrsn davidpdrsn enabled auto-merge (squash) January 13, 2024 13:42
@davidpdrsn davidpdrsn merged commit 358f196 into main Jan 13, 2024
18 checks passed
@davidpdrsn davidpdrsn deleted the david/csrf-missing branch January 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oauth example doesn't validate CSRF token
2 participants
@davidpdrsn @jplatte