Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes #7

Open
cdarken opened this issue May 2, 2018 · 2 comments
Open

Cosmetic changes #7

cdarken opened this issue May 2, 2018 · 2 comments

Comments

@cdarken
Copy link

cdarken commented May 2, 2018

I don't know if you have time or the inclination to implement this, but I'll make a list anyway, in case you do:

  • some coloring when displaying the messages in the console would be nice. For instance: green for accepted share, red for rejected, blue for the stats, yellow for new jobs, and so on.
  • keeping count of the running time and the accepted vs rejected shares.

These would make great improvements on checking the status of the miner at a glance.
Thank you.

@todxx
Copy link
Owner

todxx commented May 2, 2018

I'll add it to my todo list, but no promises.

Just to clarify, you are suggesting that I change the color of the entire line printed, correct?

Also for accepted/rejected shares, this gets a little complicated since apparently some pools (looking at you f2pool) will occasionally not reply to submitted shares. I can add something like accepted/rejected/submitted shares print out. For this, would you want to see all share stats since the miner was started, or since the pool was connected to. I.E. should I reset when the pool reconnects?

@cdarken
Copy link
Author

cdarken commented May 2, 2018

If you're familiar with how claymore's miners do it, that would be a good reference point, as most miners are familiar with them. And I would say that the stats should be cumulative while the program is running, no matter how many times it reconnects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants