Replaced pkg_resources with importlib.metadata #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of pkg_resources is discouraged in favor of importlib.resources and importlib.metadata. importlib.metadata is used in this commit to get the version string from the pyproject.toml package configuration.
|
This will break compatibility in Line 14 in 5c7a703 as |
|
As already mentioned, just requiring try:
from importlib.metadata import version
except ImportError:
# Python < 3.8
from importlib_metadata import versionwould fix this for every supported version since Python 3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of pkg_resources is discouraged in favor of importlib.resources
and importlib.metadata. importlib.metadata is used in this commit
to get the version string from the pyproject.toml package configuration.
This PR closes #22 in order to hopefully allow PyOxidizer to package the library.