Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paging: Refactor producers into classes? #244

Open
dbrgn opened this issue May 27, 2014 · 0 comments
Open

Paging: Refactor producers into classes? #244

dbrgn opened this issue May 27, 2014 · 0 comments
Labels
BACKEND improvement

Comments

@dbrgn
Copy link
Member

dbrgn commented May 27, 2014

I had some concerns regarding the original implementation (009d6eb), especially because the client (browser) could control so much information (template path, list and stat producers that didn't even have to match). Seems better now but I still wonder if it wouldn't be better to define a base class with two methods that a paging producer implements instead of registering two functions each.

See 2ad9547#commitcomment-6448151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BACKEND improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbrgn