Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update overhead/efficiency #27

Closed
casperdcl opened this issue Feb 21, 2019 · 3 comments · Fixed by #56
Closed

update overhead/efficiency #27

casperdcl opened this issue Feb 21, 2019 · 3 comments · Fixed by #56

Comments

@casperdcl
Copy link
Collaborator

casperdcl commented Feb 21, 2019

Things like nvidia-smi can take some time to run (up to a few seconds) so we should try to call them only once per update. Right now, using e.g. #{gpu_icon} #{gpu_percentage} will call nvidia-smi twice.

Fixing this will also help with #5

@casperdcl
Copy link
Collaborator Author

also @ctjhoa considering #22 #27 #28 #29 and git fame -wtMC --excl='\.png$' I'm responsible for about 1/4 of this repo (LoC) or 1/3 (files) - would be nice to be added as a collaborator/team member :)

@ctjhoa
Copy link
Member

ctjhoa commented Feb 27, 2019

@casperdcl

would be nice to be added as a collaborator/team member :)

Sure, that's what I had in mind. Unfortunately, I don't think I'm able to do that myself. As this plugin is part of the tmux-plugins organization, only the organization's owner is able to add new collaborators.

@bruno- can you add @casperdcl as collaborator of this project, please? Thanks

@ctjhoa
Copy link
Member

ctjhoa commented Oct 11, 2019

Since github upgrade I've managed to invite you as collaborator. Another information not directly related but with 0e6fb34 I have added customization on the format used to display percentage. So I've change the default gpu_percentage_format to %3.1f%% (formerly %3.0%%) which add one decimal, this was needed to get the same behavior between cpu and gpu. Thanks

casperdcl added a commit that referenced this issue Jul 9, 2020
- fixes #27
- fixes #15
- fixes #5
casperdcl added a commit that referenced this issue Jul 9, 2020
- fixes #27
- related #15
- related #5
casperdcl added a commit that referenced this issue Jul 9, 2020
- fixes #27
- related #15
- related #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants