Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other maps source #8

Open
DGrv opened this issue Oct 17, 2018 · 7 comments
Open

Add other maps source #8

DGrv opened this issue Oct 17, 2018 · 7 comments
Milestone

Comments

@DGrv
Copy link

DGrv commented Oct 17, 2018

Hi,

I did not look in detail your code, I have in all case not enough knowledge in this to understand everything.
I really appreciate your work and your tool. I am also French so I totally understand the need of this with the IGN. Actually I am leaving in Germany and I would also like to use it, however the maps are not really satisfying my need, you would understand.

So I come to my question, is it possible to implement other maps ? and how ? (OpenTopo, for example, or Kompass eventually - but may not be allowed).

Thanks

@tmuguet
Copy link
Owner

tmuguet commented Oct 18, 2018

Hi,

Thanks for your interest!

There are three reasons I am currently using IGN services: displaying the maps, computing routes and retrieving additional data (altitude, slopes, etc.):

  • Displaying other maps would be possible and fairly straight-forward.
  • Routing would require additional services, like GraphHopper, which is not easily doable currently.
  • Some additional data may not be available (slopes for instance).

I am currently heavily refactoring the code, which should allow me to add other services more easily later. I expect to finish my refactoring in November, so maybe in December 2018 I'll have some time to fully tackle this issue.

@DGrv
Copy link
Author

DGrv commented Oct 29, 2018

Sound great :) Thanks.
What do you need to implement new maps ? a simple url tile is sufficient ?
If I can help tell me.

@tmuguet
Copy link
Owner

tmuguet commented Nov 9, 2018

For new maps, I'll check myself the APIs/tile URLs and licenses, this is really the easy part :)
You mentioned OpenTopoMap, which seems great. I am not sure what data Kompass uses, it seems proprietary. I was also thinking of MapBox, which is free for small traffic. If you have any other service in mind, I'll be glad to have a look at them.

@tmuguet
Copy link
Owner

tmuguet commented Jan 11, 2019

Hi,

Sorry for the delay, I was really busy with my day job, but I have some good news for you :)
I managed to get to a state where the new version is ready for some testing at http://map2gpx.eu/. So far, I have added maps from OpenCycleMap, OpenTopoMap, Hike&Bike and Hillshading.

I will look into the licenses of the other layers once I'm done with adding undo/redo capability and I have more thoroughly tested and documented the app.

@tmuguet tmuguet added this to the v2 milestone Jan 12, 2019
@DGrv
Copy link
Author

DGrv commented Jan 18, 2019

Hi,

Great. This is really nice.
I tested what I could and did not see bugs.

Do you wanna stay with the eu and fr separated or plan to merge them at one point.

Thanks a lot :)

@tmuguet
Copy link
Owner

tmuguet commented Jan 31, 2019

Hi,

Thanks for your feedback!
For now I did not found a nice way to merge them, so both websites will coexist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants