Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mustache.js with own fork #233

Open
neocotic opened this issue Nov 13, 2017 · 1 comment
Open

Replace mustache.js with own fork #233

neocotic opened this issue Nov 13, 2017 · 1 comment
Milestone

Comments

@neocotic
Copy link
Member

We've always used a custom implementation of mustache.js, however, I'd like to move our modified version into a separate repository to make maintaining it much easier.

https://github.com/tmplat-extension/tmplat-mustache

We should then depend on it within the extension.

@neocotic neocotic added this to the 2.0.0 milestone Nov 13, 2017
@neocotic
Copy link
Member Author

Alternatively, I'm considering about simply replacing our custom implementation with pure mustache.js, however, this would be a massive breaking change and I doubt users would understand or be happy with it, so I'm simply considering it at this stage. It would make maintenance much easier.

That said; using the latest version of mustache.js is proving difficult. Mainly because it's much better structured than 0.7.2, which our custom implementation is currently based on. I'm tempted to just fork this version and use our file as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant