Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch dark/light diagrams based on theme, not just with @media (prefers-color-scheme: dark) #43

Open
heeckhau opened this issue Sep 20, 2023 · 2 comments
Open

Switch dark/light diagrams based on theme, not just with @media (prefers-color-scheme: dark) #43

heeckhau opened this issue Sep 20, 2023 · 2 comments

Comments

@heeckhau
Copy link
Member

No description provided.

heeckhau added a commit that referenced this issue Sep 20, 2023
@heeckhau
Experiment with dark diagram switch
70bf41e 
#43
@heeckhau
Copy link
Member Author

heeckhau commented Oct 9, 2023

There is no easy way to do this.

The svgs in this PR don't look good because some css styling messes with the layout.

Note that rust-book also looked into this. Without success
rust-lang/book#74

@sinui0
Copy link
Member

sinui0 commented Oct 9, 2023

Ah I see you've already looked into the color issue. We can just use a color palette which inverts well in our diagrams

@jeremyle56 jeremyle56 mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heeckhau @sinui0