Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually execute checks defined in base classes #376

Open
t184256 opened this issue Nov 27, 2019 · 5 comments
Open

Actually execute checks defined in base classes #376

t184256 opened this issue Nov 27, 2019 · 5 comments
Assignees
Labels
bug unintented behaviour in tlslite-ng code good first issue relatively simple changes, good for first time contributors help wanted

Comments

@t184256
Copy link
Collaborator

t184256 commented Nov 27, 2019

Several base classes for crypto algorithms contain sanity checks that never get executed in children classes, which is misleading and could lead to inconsistent error reporting across implementations.

@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Nov 27, 2019
@tomato42 tomato42 added this to the someday/future milestone Nov 27, 2019
@t184256
Copy link
Collaborator Author

t184256 commented Nov 27, 2019

Example (AES, others have similar variety):

Also, 3DES python implementation does not inherit from the base class at all.

@tomato42 tomato42 added good first issue relatively simple changes, good for first time contributors help wanted labels Nov 27, 2019
@tomato42
Copy link
Member

Given the test coverage from tlsfuzzer, it doesn't look like it's something visible/exploitable/inconsistent on TLS level, but it would be nice to fix it to reduce code duplication and unify behaviour between implementations. Mostly so that external users can depend on consistent behaviour of the decryption functions, irrespective of the selected concrete implementation.

@rajdroid
Copy link

@tomato42 if there is no deadline attached I can take a look at this request.

@tomato42
Copy link
Member

tomato42 commented Jan 2, 2020

@rajdroid there is no deadline, feel free to pick it up

@rajdroid
Copy link

rajdroid commented Jan 2, 2020

@tomato42 please assign it to me then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code good first issue relatively simple changes, good for first time contributors help wanted
Projects
None yet
Development

No branches or pull requests

3 participants