Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle delete_* capabilities #2

Open
marcochiesi opened this issue Aug 29, 2014 · 2 comments
Open

Handle delete_* capabilities #2

marcochiesi opened this issue Aug 29, 2014 · 2 comments
Assignees

Comments

@marcochiesi
Copy link
Collaborator

The current version of the plugin only handles edit_* capabilities but not delete_*. This brings to odd situations where a user cannot edit a post, but he can delete it, which is paradoxical.
Example: if you create a page and set it as accessible by Admin only, Editors will be able to delete it while not being able to edit. Since this is a very typical use case, I think it should be addressed somehow. You should add the proper delete capabilities when you check for permissions.

A further step would be to have separate settings for editing and deleting items. Example: an Editor should be able to edit a particular page, but not the delete it.

@marcochiesi
Copy link
Collaborator Author

What do you think about adding unit testing for delete_* capabilities too?

@tlovett1
Copy link
Owner

tlovett1 commented Oct 8, 2014

+1000 on unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants