Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap()s expect()s and other panic!("the disco") #13

Open
gshipunov opened this issue Mar 9, 2023 · 0 comments
Open

unwrap()s expect()s and other panic!("the disco") #13

gshipunov opened this issue Mar 9, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gshipunov
Copy link
Member

This is a library. Anything that can lead to panic should only be acceptable due to a bug. Any errors needs to be either handled or propagated to the caller, so the service using the library can decide if it needs to panic in this situation by itself.

Should be an easy fix, just grep for any unwrap()y code, and write some custom error enums.

@gshipunov gshipunov added the enhancement New feature or request label Mar 9, 2023
@gshipunov gshipunov mentioned this issue Mar 10, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants