Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #42

Open
tlf30 opened this issue Dec 6, 2021 · 7 comments
Open

Release v1.0.0 #42

tlf30 opened this issue Dec 6, 2021 · 7 comments

Comments

@tlf30
Copy link
Owner

tlf30 commented Dec 6, 2021

Hello everyone,
I am interested in cutting a release v1.0.0.

Notably, this release will have a breaking change of bumping the jme version to v3.4.1. While no code in the library will be modified as part of this change, this will remove support for projects running older versions of JME. If the community has an issue with this, I can leave jme at 3.3.0 and update everything else.

As part of this release, I will be updating netty.io to 4.1.70, which contains a large number of internal bug and performance improvements.

I will also be releasing this on maven central, which will make it even simpler to include in your maven or gradle build configuration.

@oxplay2, do you have any feedback on these changes?

@oxplay2
Copy link

oxplay2 commented Jan 31, 2022

ah, sorry i didnt look at github for more than month

sure, i anyway always stick with new JME releases.

@tlf30
Copy link
Owner Author

tlf30 commented Jan 31, 2022

Sounds good. I'll pull in the latest updates then push a release out. I'm flying to work today and tomorrow so it may have to wait a couple days.

@tlf30
Copy link
Owner Author

tlf30 commented Sep 20, 2022

@oxplay2 I pushed these changes in the recent #44 merge request. And published a snapshot of v0.1.2 to maven central.

@oxplay2
Copy link

oxplay2 commented Sep 23, 2022

ok, im working on other things currently, but will update as soon as i can.

Thanks a lot! :)

@oxplay2
Copy link

oxplay2 commented Oct 11, 2022

@tlf30 wasnt 0.1.2 snapshot already exist? it replaced old one?

i ask because i already had 0.1.2 as i understand you mean 1.0.0 but i didnt see one

@tlf30
Copy link
Owner Author

tlf30 commented Oct 11, 2022

Hmm, I do not know of any 0.1.2 version published in the past, unless you had a local build. This is the first snapshot on maven, but on GitHub packages there has only been a 0.1.1 release.

Now that the maven publish works and everything is updated to the latest without issues (as far as I know) I would like to cut a v1.0.0 release.

@oxplay2
Copy link

oxplay2 commented Oct 11, 2022

yes, i had local build

(i needed examples for some file)
earlier i had:

    implementation name: "monkey-netty-0.1.2-SNAPSHOT"
    implementation name: "examples-0.1.2-SNAPSHOT"

(readed from local "libs" folder)
now i changed to:

    implementation 'io.tlf.monkeynetty:monkey-netty:0.1.2-SNAPSHOT'
    implementation 'io.tlf.monkeynetty:examples:0.1.2-SNAPSHOT'

(that i assume should read from maven repo (via our proxy repo))

but i didnt seen gradle to download anything new, so i assume it read it from cache without download anyway.

it was long time ago and i didnt even remember from where/when i had this local build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants