Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move message "X of X tools displayed" somewhere else on the page #268

Open
jonespm opened this issue Aug 4, 2022 · 4 comments
Open

Move message "X of X tools displayed" somewhere else on the page #268

jonespm opened this issue Aug 4, 2022 · 4 comments
Labels
enhancement New feature or request frontend

Comments

@jonespm
Copy link
Member

jonespm commented Aug 4, 2022

This was mentioned on a comment on a PR. I'd mentioned that we have a message now on the top of the page that takes up around 10% horizontal space and could use some UX/UI feedback.

What I saw was that we might make it an Input Adornment on top or bottom of the search box but still have aria announce the change. These seem to fit really well and be right in context with the input.

This example shows when it changes but I didn't test if it was accessible.

Originally posted by @jonespm in #250 (comment)

@jonespm jonespm added enhancement New feature or request frontend labels Aug 4, 2022
@ssciolla
Copy link
Contributor

ssciolla commented Aug 4, 2022

I asked Janel for feedback.

@ssciolla ssciolla self-assigned this Aug 4, 2022
@janelilr
Copy link

While I know this is a filter feature, I looked at several websites where they have the search field and display “# of results” text. The “# of results” text is located closer to the result items rather than near the search field. For CAE, leaving the text where it is would fit a familiar pattern to the user.

The current spacing doesn't look cramp so leaving it as is would be fine. If you are wanting to reduce how much space it takes up, try reducing the margin of the H2 and p.

@jonespm
Copy link
Member Author

jonespm commented Sep 2, 2022

Thanks @janelilr, that makes sense now that I'm looking at it too.

  • For Example on Google
    image

  • And on Github
    image

Both of those are left aligned though, and in the Google both cases the styling is quite different so it stands out. I think it's fine, and we could maybe just adjust the placement or the margin.

Perhaps it's another question but do you think the H2 we have makes sense where it is? Perhaps it's just with both of those on separate lines, especially on Mobile is where it seems like there's a lot of space taken up. Maybe this is another issue.

image

<h2 class="MuiTypography-root MuiTypography-h6 css-1y8dxs3">Find the best tools for your class and students</h2>

@janelilr
Copy link

janelilr commented Sep 2, 2022

The H2 makes sense where it is. It gives an indication what the user can do.

@ssciolla ssciolla removed their assignment Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

No branches or pull requests

3 participants