Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cot log name when user changes callsign #76

Open
skadakar opened this issue Aug 20, 2022 · 3 comments
Open

Change cot log name when user changes callsign #76

skadakar opened this issue Aug 20, 2022 · 3 comments

Comments

@skadakar
Copy link
Contributor

Currently the cot logs on disk reflect the first name the UID is seen with as far as I can tell, making it difficult to find the right logs some times.

@tkuester
Copy link
Owner

tkuester commented Feb 5, 2023

I have an idea on how to resolve this! Instead of using the user's identified callsign / UID (which can change), we could specify the certificate they used to connect with.

That is, if you assign them the certificate JENNY, that's the name of the logfile.

This would also solve a few other issues, such as not knowing which logfile to send data to initially. (Although, obviously, with TCP only this wouldn't work.)

@skadakar
Copy link
Contributor Author

skadakar commented Feb 5, 2023

In my case this is semi-public servers, so the same datapackage is used by whoever wants to join, so this approach would not work.

To replicate this scenario you need a user to connect to taky, then change their callsign.
As the user has changed callsign you expect <uid>-<new-callsign>.cot you get <uid>-<old-callsign>.cot.

I suspect fixing this would add overhead to each individual cot read, having to check for callsign and uid every time, so might not be worth it as UID will remain correct, even if callsign is not updated.

@skadakar
Copy link
Contributor Author

skadakar commented Feb 5, 2023

The scenarios where this is relevant is when a user is having connection issues and you struggle to find their logs, you can easily just grep for their callsign to figure it out - so any relevant overhead for fixing this is probably not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants