New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace console.assert() with Facebook's invariant #6

Open

tkrotoff opened this issue Oct 31, 2017 · 3 comments

Labels

enhancement question

Owner

tkrotoff commented Oct 31, 2017

See https://github.com/zertosh/invariant
See https://github.com/facebook/fbjs/blob/c69904a511b900266935168223063dd8772dfc40/packages/fbjs/src/__forks__/invariant.js

tkrotoff added enhancement question labels

Owner Author

tkrotoff commented Feb 6, 2019 •

edited

Loading

See https://github.com/BerkeleyTrue/warning, used by Material-UI: https://david-dm.org/mui-org/material-ui?path=packages%2Fmaterial-ui

Owner Author

tkrotoff commented Jun 17, 2019

The real issue is here: https://github.com/tkrotoff/react-form-with-constraints/blob/v0.12.0/packages/react-form-with-constraints/src/FormWithConstraints.tsx#L113

The console.assert() here can make user tests fail.

Owner Author

tkrotoff commented Mar 10, 2020

See 340db73, packaged with v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment