Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor issues #13

Open
zmuranaka opened this issue Jun 5, 2024 · 0 comments · May be fixed by #14
Open

Various minor issues #13

zmuranaka opened this issue Jun 5, 2024 · 0 comments · May be fixed by #14

Comments

@zmuranaka
Copy link

There is no analysis_options.yaml included in the project. Just by including this in the project with the default recommended Flutter lints we can see the following issues:

  • PinchZoom constructor can be const
  • PinchZoom constructor does not expose a Key? parameter
  • Recommended to not expose private _PinchZoomState in public API PinchZoom
  • _endScrollTimer can use a const Duration

There were two other improvements that I noticed could be made:

  • The [resetDuration] parameter has been removed from the PinchZoom constructor but it is still referenced in the documentation comment here.
  • The PinchZoom class is missing a dispose method implementation even though _transformationController and _overlayEntry are disposable, and _endScrollTimer is cancelable.
@zmuranaka zmuranaka linked a pull request Jun 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant