You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is no analysis_options.yaml included in the project. Just by including this in the project with the default recommended Flutter lints we can see the following issues:
PinchZoom constructor can be const
PinchZoom constructor does not expose a Key? parameter
Recommended to not expose private _PinchZoomState in public API PinchZoom
_endScrollTimer can use a const Duration
There were two other improvements that I noticed could be made:
The [resetDuration] parameter has been removed from the PinchZoom constructor but it is still referenced in the documentation comment here.
The PinchZoom class is missing a dispose method implementation even though _transformationController and _overlayEntry are disposable, and _endScrollTimer is cancelable.
The text was updated successfully, but these errors were encountered:
There is no analysis_options.yaml included in the project. Just by including this in the project with the default recommended Flutter lints we can see the following issues:
PinchZoom
constructor can be constPinchZoom
constructor does not expose aKey?
parameter_PinchZoomState
in public APIPinchZoom
_endScrollTimer
can use a const DurationThere were two other improvements that I noticed could be made:
PinchZoom
constructor but it is still referenced in the documentation comment here.PinchZoom
class is missing adispose
method implementation even though_transformationController
and_overlayEntry
are disposable, and_endScrollTimer
is cancelable.The text was updated successfully, but these errors were encountered: