From e69eb227429d2939c6c48c9c776181995cbd0df0 Mon Sep 17 00:00:00 2001 From: Timo Kokkonen Date: Mon, 15 Jul 2024 20:37:05 -0700 Subject: [PATCH] Change default LRA intepretation to be LOW=1000 rpm and HIGH=0 rpm (rotor locked). (#90) --- commands.md | 16 ++++++++-------- src/config.c | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/commands.md b/commands.md index 0b79eb7..db41976 100644 --- a/commands.md +++ b/commands.md @@ -416,14 +416,14 @@ Locked Rotor (Alarm)|LRA,low_rpm,high_rpm|Parameters indicate mapping from LRA t Default: TACHO (fan sends standard tachometer pulses to indicate rotation speed) -Example: Fan is not sending tachometer signal but Locked Rotor Alam signal (LRA) on tachometer pin (we map LOW signal to mean 0 RPM and HIGH signal to mean 2000 RPM) +Example: Fan is not sending tachometer signal but Locked Rotor Alam signal (LRA) on tachometer pin (we map HIGH signal to mean 0 RPM and LOW signal to mean 2000 RPM) ``` -CONF:FAN1:RPMMODE LRA,0,2000 +CONF:FAN1:RPMMODE LRA,2000,0 ``` -Example: Fan is sending Locked Rotor (Alarm) signal (LRA), where polarity in reversed (HIGH signal indicates lockup/failure): +Example: Fan is sending Locked Rotor (Alarm) signal (LRA), where polarity in reversed (LOW signal indicates lockup/failure): ``` -CONF:FAN2:RPMMODE LRA,2000,0 +CONF:FAN2:RPMMODE LRA,0,2000 ``` #### CONFigure:FANx:RPMMOde? @@ -676,14 +676,14 @@ Locked Rotor (Alarm)|LRA,treshold_rpm,locked_signal_level|Send Locked Rotor Alar Default: TACHO (standard tachometer pulses to indicate rotation speed) -Example: Send 'LOW' Locked Rotor (Alarm) signal (when RPM drops below 200 RPM) +Example: Send 'HIGH' Locked Rotor (Alarm) signal (when RPM drops below 200 RPM) ``` -CONF:MBFAN1:RPMMODE LRA,200,LOW +CONF:MBFAN1:RPMMODE LRA,200,HIGH ``` -Example: Send 'HIGH' Locked Rotor (Alarm) signal (when RPM drops below 500 RPM) +Example: Send 'LOW' Locked Rotor (Alarm) signal (when RPM drops below 500 RPM) ``` -CONF:MBFAN2:RPMMODE LRA,500,HIGH +CONF:MBFAN2:RPMMODE LRA,500,LOW ``` #### CONFigure:FANx:RPMMOde? diff --git a/src/config.c b/src/config.c index 61c1b46..4c0afa6 100644 --- a/src/config.c +++ b/src/config.c @@ -464,8 +464,8 @@ void clear_config(struct fanpico_config *cfg) f->s_id = 0; f->map.points = 0; f->rpm_mode = RMODE_TACHO; - f->lra_low = 0; - f->lra_high = 1000; + f->lra_low = 1000; + f->lra_high = 0; f->rpm_factor = 2; f->filter = FILTER_NONE; f->filter_ctx = NULL;