feature/custom-storage-locations-293 #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiptr
requested review from
MarcEngelmannTUM,
lieberlois,
C-Aldenhoven and
markusweis
tiptr
changed the title
tiptr
changed the title
MarcEngelmannTUM
approved these changes
Jan 25, 2022
| return SizedBox( | ||
| width: 150, | ||
| child: StepProgressIndicator( | ||
| totalSteps: totalProdSteps, |
There was a problem hiding this comment.
In the future, a more adaptive Widget would be useful to prevent an overflow when selecting a large phasecount in the settings
| .textStyle2 | ||
| .withOnBackgroundHard | ||
| .withBold | ||
| .withOverflow(TextOverflow.ellipsis), |
There was a problem hiding this comment.
ellipsis is default, this line can be removed
| activity.pathToImage ?? | ||
| // For now, the crazy cat is the default when no path is present | ||
| 'assets/leisure/leisure-fun-smiling-cats.svg', | ||
| color: Colors.cyan), |
There was a problem hiding this comment.
This should be the tertiary color
| // Leisure description | ||
| Text( | ||
| activity.descriptionLong ?? activity.descriptionShort, | ||
| overflow: TextOverflow.visible, |
There was a problem hiding this comment.
There is a TextStyle called settingsInfoTextStyle to display longer descriptive texts. You can use it here (and rename it)
| import 'package:shared_preferences/shared_preferences.dart'; | ||
|
|
||
| class SharedPreferencesData { | ||
| static late SharedPreferences _prefs; | ||
| static late String _defaultStorageLocation; |
There was a problem hiding this comment.
default values are stored in a different file (settings_constants.dart). This class always returns nullables and the default value has to be used in the calling location, if null is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
This also does some other minor improvements and bugfixes: