Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout incorrect in SetTx function #10

Open
Pete9008 opened this issue Dec 31, 2022 · 1 comment
Open

Timeout incorrect in SetTx function #10

Pete9008 opened this issue Dec 31, 2022 · 1 comment

Comments

@Pete9008
Copy link

Pete9008 commented Dec 31, 2022

The Timeout is incorrectly calculated in SetTx meaning that the transmission fails on longer or slow messages, see 5f63e8a for details.
Many thanks.

@Cale-Torino
Copy link

@Pete9008

1000% correct I was getting very low power output... wasted a lot of time almost went to another library.
Then after changing the time to uint32_t tout = (uint32_t)(timeoutInMs * (1.0/0.015625)); all of a sudden everything worked as intended.

Here's some images for visual aid:

Wimpy signal with uint32_t tout = (uint32_t)(timeoutInMs * 0.015625);
Screenshot 2024-05-02 223345

Chad signal with uint32_t tout = (uint32_t)(timeoutInMs * (1.0/0.015625));
Screenshot 2024-05-02 223243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants