Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootio action will panic if MIRROR_HOST is set incorrectly #130

Open
agruetz opened this issue May 9, 2024 · 1 comment
Open

rootio action will panic if MIRROR_HOST is set incorrectly #130

agruetz opened this issue May 9, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@agruetz
Copy link

agruetz commented May 9, 2024

If you set an invalid/non-existant metadata server for the MIRROR_HOST env the rootio action will throw a nil pointer error.

Expected Behaviour

The rootio action should gracefully handle an incorrectly set MIRROR_HOST or if the metadata service does not respond with all the correct informaiton.

Current Behaviour

panic at line 48 of rootio/cmd/rootio.go

Possible Solution

Better error handling an nil pointer checking before usage of metadata.Instance.Storage.Disks on line 48.

Steps to Reproduce (for bugs)

  1. Set incorrect MIRROR_HOST in template file when using the rootio action
  2. PXE boot physical device
  3. docker logs tink-worker --follow

Context

The issue is minor and using the correct MIRROR_HOST for the metadata service works as expected. It did cause confusion and debug time as it is not clear what MIRROR_HOST was used for and what was causing the panic.

Your Environment

Physical Intel NUC 11's with a Ubiquiti Router.

@chrisdoherty4
Copy link
Member

Thanks, @agruetz. We'll take a look.

@chrisdoherty4 chrisdoherty4 added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants