Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildpack fails on Heroku-22 due to no system Ruby #18

Open
edmorley opened this issue Jun 30, 2022 · 3 comments
Open

Buildpack fails on Heroku-22 due to no system Ruby #18

edmorley opened this issue Jun 30, 2022 · 3 comments

Comments

@edmorley
Copy link

Hi!

The Heroku-22 stack was just released:
https://devcenter.heroku.com/changelog-items/2429

However in Heroku-22, there is no longer a system install of Ruby:
https://devcenter.heroku.com/articles/heroku-22-stack#system-ruby-is-no-longer-installed

This buildpack is written entirely in Ruby, and so currently does not work on Heroku-22.

Heroku has it's own fork of this buildpack (https://github.com/heroku/heroku-buildpack-github-netrc), which has solved the issue with Heroku-22 by converting the buildpack to use bash scripts instead of Ruby:
heroku/heroku-buildpack-github-netrc#3

I would recommend either:

  1. Pulling in those changes into this repo.
  2. Or, if you no longer wish to maintain this repo (now that there's a Heroku version), adding deprecation warning messages to the output of this buildpack encouraging users to migrate to the Heroku version.

Many thanks :-)

@edmorley
Copy link
Author

edmorley commented Sep 1, 2022

I would recommend either:

1. Pulling in those changes into this repo.

2. Or, if you no longer wish to maintain this repo (now that there's a Heroku version), adding deprecation warning messages to the output of this buildpack encouraging users to migrate to the Heroku version.

@timshadel Hi! Any thoughts on the above? :-)

@timshadel
Copy link
Owner

@edmorley wow! I had no idea this repo was still being used by others. I'm happy to bring in the changes blindly from the Heroku "fork-not-fork", but as I'm not actively using this buildpack I'd need someone to try it out. Would you be willing to help me out with testing?

@edmorley
Copy link
Author

edmorley commented Nov 8, 2022

@timshadel Hi! Thank you for the reply.

People are already using https://github.com/heroku/heroku-buildpack-github-netrc and manual testing for the conversion from Ruby to bash was also performed in:
heroku/heroku-buildpack-github-netrc#3 (comment)

However, if you don't use this buildpack any more, perhaps a deprecation warning (or hard failure) might be best? (That suggests people switch to https://github.com/heroku/heroku-buildpack-github-netrc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants