Replies: 4 comments 3 replies
-
You have led the arguments to keep it as JS. I vote for it. |
Beta Was this translation helpful? Give feedback.
0 replies
-
@DoctorDerek @aloisdg how about javascript files with jdoc types like xdm? Got the inspiration from there while experimenting with it. Or are you looking for a strict typescript version of the code? |
Beta Was this translation helpful? Give feedback.
1 reply
-
Personally I prefer TypeScript because despite its quirks there's going to
be strict type checking integrated into the build step.
It's not error proof, since undefined values can come from the Markdown
files resulting in run-time errors that TypeScript would normally prevent
(e.g. .map() is not a function), but I find it incredibly useful as a type
of self-documenting code.
Some people hate TypeScript vehemently, though. 🙂 In my experience
converting a fork of this project, everything is straightforward except the
lib/utils files, some of which would need to be rewritten.
|
Beta Was this translation helpful? Give feedback.
2 replies
-
I prefer TS, but I'd be happy with a conversion guide. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Had a few requests for typescript but I also want to get a sense of the broader user base / potential users. Should we keep it as js or migrate to ts? Since this is a template which people clone and modify, I tried to keep it as accessible as possible i.e. js. We can consider improving the developer experience with JSDoc comments but I am not sure about fully adopting typescript.
Alternatively, if you know of ways where repo templates cater to both js and ts in a convenient manner, happy to hear about them.
Beta Was this translation helpful? Give feedback.
All reactions