Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Make business metrics easily accessible for the Rebalancer #40

Open
12 of 15 tasks
uditvira opened this issue Apr 10, 2024 · 7 comments
Open
12 of 15 tasks

[EPIC] Make business metrics easily accessible for the Rebalancer #40

uditvira opened this issue Apr 10, 2024 · 7 comments
Assignees

Comments

@uditvira
Copy link
Contributor

uditvira commented Apr 10, 2024

We need the certain information easily accessible to give us an insight about how the rebalancer is doing (e.g., do we have sufficient market making capacity)

Summary of information we need

  • Number of accounts (separated out by active and inactive/paused) - This is done
  • Total amount being managed in valence accounts - We decided not to calculate the total value, instead we can just calculate the aggregate balances of each individual denom across all accounts
  • When did the last rebalancing occur - The purpose of this is to ensure that the rebalancer is running each day. We can monitor this on Slack now thanks to the slackbot
  • When will the next rebalancing occur - It occurs at midnight UTC
  • What was the volume in the last rebalancing - This is coming through in the slackbot
  • From the last rebalancing, how much was successfully auctioned off vs. how much was returned back to the users due to lack of market making activity We decided to remove this, given our mm contract is successfully running and the arb bot is about to be functional
  • For each auction, what was the price of the last successful bid - Missing, will be fixed soon
  • For each auction, how does the price of the last successful bid compare to prices on a CEX - This is handled by the front end

This information should be easily accessible for non technical people on the team. Ideally, this can be scripted up and available as a JSON. We can build a UI around this in the future


Tasks

@stiiifff
Copy link
Contributor

stiiifff commented Apr 15, 2024

Some basic metrics:

  • Is it running (righ now), when was the last crossing, and bid by the bot ?
  • Capital efficiency of the trade execution (wrt. price disco on CEX e.g. Binance API)

@maximusdm1
Copy link

Questions:

  1. For these, is it by auction or by account? "When did the last rebalancing occur, When will the next rebalancing occur, What was the volume in the last rebalancing"

  2. Is this metric the amount of capital we were short in order for our market making to handle the full amount? "From the last rebalancing, how much was successfully auctioned off vs. how much was returned back to the users"

Requests

  1. [high priority] If the answer to Should we set a time limit for using a service? #2 above is "yes", can we trigger some sort of automatic alert if it is ever greater than 0 so that I can respond quickly?

  2. [medium low priority] would be great to have churn metrics. how much capital has remained in the system, how much as left the system, and how much is net-new.

@uditvira
Copy link
Contributor Author

Discussed with @maximusdm1 on a call:

  • we should be tracking active vs inactive accounts
  • after we can capture these metrics, we should add an alerting system for certain events such as when the auction system is unable to auction of funds due to a lack of market making activity

@Art3miX
Copy link
Collaborator

Art3miX commented May 9, 2024

This should be a milestone rather then a single issue, we have separate parts to this issue, and separate uses for those parts.

@stiiifff
Copy link
Contributor

Agreed. I suggest to keep this issue as is though (and leave it in "On hold" ) state, and to link to it from newly created finer-grained ones.

@uditvira
Copy link
Contributor Author

uditvira commented Jun 6, 2024

Revising this:

  • Number of accounts (separated out by active and inactive/paused) - This is done
  • Total amount being managed in valence accounts - We decided not to calculate the total value, instead we can just calculate the aggregate balances of each individual denom across all accounts
  • When did the last rebalancing occur - The purpose of this is to ensure that the rebalancer is running each day. We can monitor this on Slack now thanks to the slackbot
  • When will the next rebalancing occur - It occurs at midnight UTC
  • What was the volume in the last rebalancing - This is coming through in the slackbot
  • From the last rebalancing, how much was successfully auctioned off vs. how much was returned back to the users due to lack of market making activity - We decided to remove this, given our mm contract is successfully running and the arb bot is about to be functional
  • For each auction, what was the price of the last successful bid - Missing, will be fixed soon
  • For each auction, how does the price of the last successful bid compare to prices on a CEX - This is handled by the front end

Updated this above

@uditvira uditvira changed the title Make business metrics easily accessible for the Rebalancer EPIC: Make business metrics easily accessible for the Rebalancer Jun 6, 2024
@stiiifff stiiifff changed the title EPIC: Make business metrics easily accessible for the Rebalancer [EPIC] Make business metrics easily accessible for the Rebalancer Jun 7, 2024
@stiiifff
Copy link
Contributor

@elenamik @Art3miX to sync and define what remains to be done for this issue (please update the issue once you've synced).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants