Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup temporary files #135

Closed
blshkv opened this issue Jun 15, 2023 · 2 comments · May be fixed by #137
Closed

cleanup temporary files #135

blshkv opened this issue Jun 15, 2023 · 2 comments · May be fixed by #137

Comments

@blshkv
Copy link

blshkv commented Jun 15, 2023

version 0.92.0
after running the following command:
gopro-dashboard.py --video-time-end file-modified --use-gpx-only --gpx ./Afternoon_Ride.gpx --layout-xml ./layout.xml ./20230614175306_00822.MP4 ./20230614175306_00822_out2.MP4
it were the following two files left over in my system:
/tmp/{tmpqaxw5ryg, tmpt2f2c4es}

Please make sure that all temporary files are removed
@time4tea
Copy link
Owner

Hi. Thanks for using the software and taking time to report a defect.
This is not a priority.

@time4tea time4tea closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@blshkv
Copy link
Author

blshkv commented Jun 19, 2023 •
edited
Loading

https://github.com/time4tea/gopro-dashboard-overlay/blob/main/gopro_overlay/common.py#L24

Python tempfile

mkstemp() and mkdtemp are lower-level functions which require manual cleanup.

So basically you either need to use a high level function (with delete=True option), or add a specific code to delete the file.

blshkv added a commit to blshkv/gopro-dashboard-overlay that referenced this issue Jun 19, 2023
@blshkv
clean up tmp file
7367fdc 
fix time4tea#135
@blshkv blshkv mentioned this issue Jun 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean up tmp file blshkv/gopro-dashboard-overlay
2 participants
@blshkv @time4tea