Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a singular pagination dto class to avoid duplication #76

Open
chrispinkney opened this issue Apr 23, 2024 · 2 comments
Open

Create a singular pagination dto class to avoid duplication #76

chrispinkney opened this issue Apr 23, 2024 · 2 comments
Labels
api API related issue

Comments

@chrispinkney
Copy link
Member

We have...

  @IsInt()
  @IsOptional()
  per_page = 10;

  @IsInt()
  @IsOptional()
  page_number = 0;

in a few places now (user, movie, list), it'd be a good idea to create a single dto file somewhere and call it instead of doing this 3 times.

@chrispinkney chrispinkney added the api API related issue label Apr 23, 2024
@manekenpix
Copy link
Member

@chrispinkney I can't remember, was this done in one of your recent PRs?

@chrispinkney
Copy link
Member Author

@manekenpix No, I think we talked about it but I forgot to implement it 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related issue
Projects
None yet
Development

No branches or pull requests

2 participants