Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSA and generics (go1.18) #38

Closed
Tracked by #2649
ldez opened this issue Mar 24, 2022 · 5 comments · Fixed by #41
Closed
Tracked by #2649

SSA and generics (go1.18) #38

ldez opened this issue Mar 24, 2022 · 5 comments · Fixed by #41

Comments

@ldez
Copy link
Contributor

ldez commented Mar 24, 2022 •
edited
Loading

Currently, SSA is not working with generics.

So your linter produces a panic when it is used with generics.

There is an issue open about that in the Go repository: golang/go#48525

Inside golangci-lint, we have disabled your linters: golangci/golangci-lint#2649

You have 2 solutions:

  • waiting for a version of SSA that will support generics
  • dropping the SSA analyzers and using something else to analyze the code.

Related to golang/go#50558
@ldez ldez mentioned this issue Mar 24, 2022
Closed
13 tasks
@lklimek lklimek mentioned this issue Apr 26, 2022
Merged
4 tasks
@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

SSA has been updated and it seems to work inside golangci-lint.

@ldez ldez closed this as completed Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

in fact the problem is still here

@ldez ldez reopened this Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Jul 19, 2022

I did some more extensive testing and the issue seems to be resolved.

@ldez ldez closed this as completed Jul 19, 2022
@ldez
Copy link
Contributor Author

ldez commented Aug 15, 2022

golangci/golangci-lint#3086

@ldez ldez reopened this Aug 15, 2022
stevenh added a commit to stevenh/bodyclose that referenced this issue Nov 4, 2022
@stevenh
fix: genetic panic
36a074d 
Update dependencies to address panic on code with genetics

Fixes: timakin#38
stevenh added a commit to stevenh/bodyclose that referenced this issue Nov 4, 2022
@stevenh
fix: genetic panic
3e1685c 
Update dependencies to address panic on code with genetics

Fixes: timakin#38
@stevenh stevenh mentioned this issue Nov 4, 2022
Merged
@stevenh
Copy link
Contributor

stevenh commented Nov 4, 2022

PR #41 fixes this, tested with the case in golangci/golangci-lint#3086

~/chconn$ go vet -vettool=$(which bodyclose) ./...
~/chconn$

Yes that's no output all good :)

@pellared pellared mentioned this issue Nov 5, 2022
Closed
4 tasks
stevenh added a commit to stevenh/bodyclose that referenced this issue Nov 6, 2022
@stevenh
fix: generics panic
7e6d4ea 
Update dependencies to address panic on code with generics

Fixes: timakin#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: generics panic stevenh/bodyclose
2 participants
@stevenh @ldez