Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Zooms Out Too Much if Notes are Far From Each Other on Fretboard #7

Open
AkiraKusanagi opened this issue Nov 20, 2023 · 1 comment

Comments

@AkiraKusanagi
Copy link

AkiraKusanagi commented Nov 20, 2023

I mean, this isn't really much of an issue, but it kinda makes it harder to play if you're using a phone, I'm sure tablets would be fine. For example, if there is a note on the 1st fret of A on the Bass, then the 12th, 13th, and 14 fret, it would zoom out and make the highway very hard to see until that sequence of notes is over. It would be nice if the camera just went to an area of a fretboard completely, then switch back.

@tilk
Copy link
Owner

tilk commented Nov 26, 2023

I'm aware of this corner case. This kind of note highway discontinuity should be detected in view calculation; possible solution would be to scan the event list from front to back, and break when the range would be too big. I'd be happy to receive a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants