Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music does not play #3

Open
QEDan opened this issue Dec 10, 2021 · 6 comments
Open

Music does not play #3

QEDan opened this issue Dec 10, 2021 · 6 comments

Comments

@QEDan
Copy link

QEDan commented Dec 10, 2021

This is really great. Thank you for making this.

When I play a song in the app, the only audio is the metronome click. The music does not play. But, I can see the 3D tab for the song scrolling. I'm using LineageOS 18.1 on a Pixel 3a phone. I have version 0.0.5 of the app from F-droid.

@tilk
Copy link
Owner

tilk commented Dec 10, 2021

No, it doesn't. I should have mentioned this in the README. It's not implemented because (a) it's probably hard (the sound is encoded in some weird Wwise format), (b) implementing this would possibly make this project more of a target for lawyers and stuff.

@QEDan
Copy link
Author

QEDan commented Dec 10, 2021

I see. That's a bit disappointing, but I understand the reasons. Thanks for responding.

I do think it would be helpful to explain this in the README and the F-droid description to help set expectations for users.

@ghost
Copy link

ghost commented Apr 8, 2023

I know it's been ages but I would be delighted if you can test my very alpha support for just that! https://github.com/yassineim/cdlc_player/releases/tag/audio-v4

Also raised a PR which I hope will get merged despite the prebuilt *.so, the thing being that building those blobs is a big headache to document, not that it's hard or anything, just tedious.

@ghost ghost mentioned this issue Apr 8, 2023
@QEDan
Copy link
Author

QEDan commented Apr 8, 2023

@Yassineim It works! Thank you so much for adding that. I will report any problems I encounter.

@ghost
Copy link

ghost commented Apr 10, 2023

@QEDan @tilk

I added a lot of improvements that reflect both to performance and the resulting apk size. I hope you can check.

https://github.com/yassineim/cdlc_player/releases/tag/audio-v4

@sanicki
Copy link

sanicki commented Jan 6, 2024

Will the audio-playing version be added to F-Droid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants