Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PrioritizedCache #127

Closed
yiwu-arbug opened this issue Dec 9, 2019 · 4 comments
Closed

Implement PrioritizedCache #127

yiwu-arbug opened this issue Dec 9, 2019 · 4 comments
Labels
component/titan Component: Titan engine sig/engine Component: Engine (SIG)

Comments

@yiwu-arbug
Copy link
Collaborator

yiwu-arbug commented Dec 9, 2019 •
edited
Loading

Implement PrioritizedCache, which wraps a single LRUCache, but have additional API to return child Cache instances that:

  • HighPriCache: always insert into the cache with high-priority, regardless of user provided option
  • LowPriCache: always insert into the cache with low-priority, regardless of user provided option

Part of tikv/tikv#5742
@yiwu-arbug
Copy link
Collaborator Author

cc @haoxiang47

@Connor1996 Connor1996 mentioned this issue Dec 9, 2019
Open
4 tasks
@yiwu-arbug yiwu-arbug added sig/engine Component: Engine (SIG) component/titan Component: Titan engine labels Jan 31, 2020
@haoxiang47 haoxiang47 mentioned this issue Feb 2, 2020
Closed
@haoxiang47
Copy link

Hi @yiwu-arbug , sorry for late for this PCP, I had simplily add a PR: tikv/rocksdb#144 for this issue, add HighPriCache and LowPriCache two interface in rocksdb

@yiwu-arbug
Copy link
Collaborator Author

Hi @yiwu-arbug , sorry for late for this PCP, I had simplily add a PR: tikv/rocksdb#144 for this issue, add HighPriCache and LowPriCache two interface in rocksdb

Thank much for the work! Commented on the PR.

@haoxiang47 haoxiang47 mentioned this issue Feb 21, 2020
Closed
@Connor1996
Copy link
Member

As blob specific cache priority is introduced, close it tikv/rocksdb#354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/titan Component: Titan engine sig/engine Component: Engine (SIG)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yiwu-arbug @haoxiang47 @Connor1996