Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double confirm or print warn information when set max-replica to less than 3 #8959

Open
AndreMouche opened this issue Dec 30, 2024 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@AndreMouche
Copy link
Member

Enhancement Task

when we set the max-replica less than 3( mostly may be a mistake and carries high risk) with pd-ctl:

 tiup ctl:v7.5.2 pd config set max-replicas 2
Starting component ctl: /home/tidb/.tiup/components/ctl/v7.5.2/ctl pd config set max-replicas 2
Success!

As you may know, Setting max-replica to less than 3 may be a mistake and carries high risk, and I think we would better print some warning information( or let the customer do a second confirm) to alert the customer that this behavior carries high risk.

@AndreMouche AndreMouche added the type/enhancement The issue or PR belongs to an enhancement. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant