Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datarace in TestRegion #7299

Closed
lhy1024 opened this issue Nov 2, 2023 · 2 comments
Closed

Datarace in TestRegion #7299

lhy1024 opened this issue Nov 2, 2023 · 2 comments
Labels
type/ci The issue is related to CI.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 2, 2023

Flaky Test

Which jobs are failing

TestRegion

2023-11-01T18:59:31.4006775Z --- FAIL: TestRegion (3.55s)
2023-11-01T18:59:31.4007206Z     testing.go:1465: race detected during execution of test
2023-11-01T18:59:31.4007347Z FAIL
2023-11-01T18:59:31.3903699Z ==================
2023-11-01T18:59:31.3904419Z [2023/11/01 18:59:03.110 +00:00] [INFO] [cluster.go:688] ["update store stats background jobs has been stopped"]
2023-11-01T18:59:31.3904578Z WARNING: DATA RACE
2023-11-01T18:59:31.3904805Z Write at 0x000006524910 by goroutine 5757:
2023-11-01T18:59:31.3920078Z   github.com/tikv/pd/pkg/schedule/schedulers.(*Controller).ResetSchedulerMetrics()
2023-11-01T18:59:31.3920989Z       /home/runner/work/pd/pd/pkg/schedule/schedulers/scheduler_controller.go:145 +0x250
2023-11-01T18:59:31.3921467Z   github.com/tikv/pd/server/cluster.(*RaftCluster).resetMetrics()
2023-11-01T18:59:31.3922022Z       /home/runner/work/pd/pd/server/cluster/cluster.go:2183 +0x154
2023-11-01T18:59:31.3922864Z   github.com/tikv/pd/server/cluster.(*RaftCluster).runMetricsCollectionJob()
2023-11-01T18:59:31.3923405Z       /home/runner/work/pd/pd/server/cluster/cluster.go:629 +0x3b1
2023-11-01T18:59:31.3924122Z   github.com/tikv/pd/server/cluster.(*RaftCluster).Start.func4()
2023-11-01T18:59:31.3924649Z       /home/runner/work/pd/pd/server/cluster/cluster.go:342 +0x33
2023-11-01T18:59:31.3924667Z 
2023-11-01T18:59:31.3925144Z Previous write at 0x000006524910 by goroutine 6426:
2023-11-01T18:59:31.3926523Z   github.com/tikv/pd/pkg/schedule/schedulers.(*Controller).ResetSchedulerMetrics()
2023-11-01T18:59:31.3927372Z       /home/runner/work/pd/pd/pkg/schedule/schedulers/scheduler_controller.go:145 +0x250
2023-11-01T18:59:31.3927845Z   github.com/tikv/pd/server/cluster.(*RaftCluster).resetMetrics()
2023-11-01T18:59:31.3928526Z       /home/runner/work/pd/pd/server/cluster/cluster.go:2183 +0x154
2023-11-01T18:59:31.3929108Z   github.com/tikv/pd/server/cluster.(*RaftCluster).runMetricsCollectionJob()
2023-11-01T18:59:31.3929641Z       /home/runner/work/pd/pd/server/cluster/cluster.go:629 +0x3b1
2023-11-01T18:59:31.3930269Z   github.com/tikv/pd/server/cluster.(*RaftCluster).Start.func4()
2023-11-01T18:59:31.3930994Z       /home/runner/work/pd/pd/server/cluster/cluster.go:342 +0x33
2023-11-01T18:59:31.3931018Z 
2023-11-01T18:59:31.3931224Z Goroutine 5757 (running) created at:
2023-11-01T18:59:31.3940591Z   github.com/tikv/pd/server/cluster.(*RaftCluster).Start()
2023-11-01T18:59:31.3941205Z       /home/runner/work/pd/pd/server/cluster/cluster.go:342 +0x1ed8
2023-11-01T18:59:31.3941588Z   github.com/tikv/pd/server.(*Server).bootstrapCluster()
2023-11-01T18:59:31.3942029Z       /home/runner/work/pd/pd/server/server.go:746 +0x1bcf
2023-11-01T18:59:31.3942366Z   github.com/tikv/pd/server.(*GrpcServer).Bootstrap()
2023-11-01T18:59:31.3943114Z       /home/runner/work/pd/pd/server/grpc_service.go:727 +0x48f
2023-11-01T18:59:31.3943503Z   github.com/tikv/pd/tests.(*TestServer).BootstrapCluster()
2023-11-01T18:59:31.3944122Z       /home/runner/work/pd/pd/tests/cluster.go:410 +0x5e4
2023-11-01T18:59:31.3944497Z   github.com/tikv/pd/tests/pdctl/region_test.TestRegion()
2023-11-01T18:59:31.3945160Z       /home/runner/work/pd/pd/tests/pdctl/region/region_test.go:76 +0x435
2023-11-01T18:59:31.3945347Z   testing.tRunner()
2023-11-01T18:59:31.3945955Z       /opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1595 +0x238
2023-11-01T18:59:31.3946155Z   testing.(*T).Run.func1()
2023-11-01T18:59:31.3946750Z       /opt/hostedtoolcache/go/1.21.3/x64/src/testing/testing.go:1648 +0x44
2023-11-01T18:59:31.3946766Z 
2023-11-01T18:59:31.3946975Z Goroutine 6426 (running) created at:
2023-11-01T18:59:31.3947345Z   github.com/tikv/pd/server/cluster.(*RaftCluster).Start()
2023-11-01T18:59:31.3947901Z       /home/runner/work/pd/pd/server/cluster/cluster.go:342 +0x1ed8
2023-11-01T18:59:31.3948268Z   github.com/tikv/pd/server.(*Server).createRaftCluster()
2023-11-01T18:59:31.3960069Z       /home/runner/work/pd/pd/server/server.go:764 +0xf6
2023-11-01T18:59:31.3960464Z   github.com/tikv/pd/server.(*Server).campaignLeader()
2023-11-01T18:59:31.3960912Z       /home/runner/work/pd/pd/server/server.go:1704 +0x1e9e
2023-11-01T18:59:31.3961251Z   github.com/tikv/pd/server.(*Server).leaderLoop()
2023-11-01T18:59:31.3961706Z       /home/runner/work/pd/pd/server/server.go:1624 +0x1ddc
2023-11-01T18:59:31.3962134Z   github.com/tikv/pd/server.(*Server).startServerLoop.func1()
2023-11-01T18:59:31.3962556Z       /home/runner/work/pd/pd/server/server.go:621 +0x33
2023-11-01T18:59:31.3962699Z ==================

CI link

Reason for failure (if possible)

Anything else

@lhy1024 lhy1024 added the type/ci The issue is related to CI. label Nov 2, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 22, 2023

@rleungx
Copy link
Member

rleungx commented Nov 23, 2023

I'm going to close it since the start process has changed. Feel free to reopen it if it happens again.

@rleungx rleungx closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/ci The issue is related to CI.
Projects
None yet
Development

No branches or pull requests

2 participants