Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the method Clone of GRPCRateLimitConfig and RateLimitConfig is wrong #7288

Closed
CabinfeverB opened this issue Oct 30, 2023 · 0 comments · Fixed by #7289
Closed

the method Clone of GRPCRateLimitConfig and RateLimitConfig is wrong #7288

CabinfeverB opened this issue Oct 30, 2023 · 0 comments · Fixed by #7289
Assignees
@CabinfeverB
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

CabinfeverB commented Oct 30, 2023 •
edited
Loading

Bug Report

They both holds LimiterConfig which is a map.

What did you do?

find the log rate limit config is updated

What did you expect to see?

the old and the new are different.

What did you see instead?

same

What version of PD are you using (pd-server -V)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CabinfeverB CabinfeverB

Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: fix Clone in RatelimitConfig CabinfeverB/pd
1 participant
@CabinfeverB