Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSeries fails on measurements containing a dot #67

Open
wardboumans opened this issue Nov 8, 2017 · 4 comments
Open

GetSeries fails on measurements containing a dot #67

wardboumans opened this issue Nov 8, 2017 · 4 comments

Comments

@wardboumans
Copy link

wardboumans commented Nov 8, 2017

Fails: var x = client.Serie.GetSeriesAsync("p1meter", "cpuload.short").Result;

Works: var x = client.Serie.GetSeriesAsync("p1meter", "\"cpuload.short\"").Result;

influx

@wardboumans wardboumans changed the title GetSeries failed on measurements containing a dot GetSeries failes on measurements containing a dot Nov 8, 2017
@wardboumans wardboumans changed the title GetSeries failes on measurements containing a dot GetSeries fails on measurements containing a dot Nov 8, 2017
@tihomir-kit
Copy link
Owner

tihomir-kit commented Nov 9, 2017

Double-quoting is actually what InfluxDB requires. I'll have to think about it, but I'm not sure if I'll be implementing additional logic around the library API which would inspect and detect if a user passed a dot in a measurement string. I'm leaning towards the idea that the user of the library should take care of this.

@wardboumans
Copy link
Author

That particular measurement is created by Telegraf. It's not like it's invalid. I think the part thats in charge of creating the actual queries should take care of it. But your call :)

@tihomir-kit
Copy link
Owner

I didn't say the measurement was invalid, example 7 from the link I shared explain a case such as yours. When I have the time, I'll make a few unit tests and decide what to do (which might not be that soon since I'm very busy with some other stuff in the next 2-3 months - in case you need this asap).

You have a good point there and the app is already escaping special characters as per InfluxDB rules, so perhaps this should be treated in the same way.

@wardboumans
Copy link
Author

No rush man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants