New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Click event firing even when button was held #3

Open

louisiukas opened this issue Sep 20, 2014 · 0 comments

louisiukas commented Sep 20, 2014

A button click event should only be fired when the button was not held.

In Button.cpp

if (cb_onClick) {
  cb_onClick(*this);
} //fire the onClick event AFTER the onRelease

should be

if (!triggeredHoldEvent && cb_onClick) {
  cb_onClick(*this);
} //fire the onClick event AFTER the onRelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment